Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clean table state on tab change #101

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

asimonok
Copy link
Collaborator

Resolves #94

Due to performance reason we can't keep independent state for each tab so just clean tab state on change

@asimonok asimonok requested a review from mikhail-vl November 23, 2023 09:30
@asimonok asimonok self-assigned this Nov 23, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (689e034) 98.17% compared to head (4d6355b) 98.17%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files          52       52           
  Lines         879      879           
  Branches      189      189           
=======================================
  Hits          863      863           
  Misses          2        2           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Nov 23, 2023
@mikhail-vl mikhail-vl added this to the Version 2.3.0 milestone Nov 23, 2023
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 737eee3 into main Nov 23, 2023
4 checks passed
@mikhail-vl mikhail-vl deleted the feat/independent-tabs-state branch November 23, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate search fields for different tabs
3 participants